Skip to content

Delegating handler for Http redirects - #2814

Merged
TingluoHuang merged 2 commits into
actions:mainfrom
paveliak:paveliak/http-redirects
Aug 31, 2023
Merged

Delegating handler for Http redirects#2814
TingluoHuang merged 2 commits into
actions:mainfrom
paveliak:paveliak/http-redirects

Conversation

@paveliak

Copy link
Copy Markdown
Contributor

This PR adds a delegating handler that performs redirection of Http requests if Actions service responds with one of 30x codes.

There is a safety switch disabling redirection handlers (controlled by the GITHUB_ACTIONS_RUNNER_NO_HTTP_REDIRECTS environment variable). It does not however control server behavior and if this environment is set and server responds with a redirect then job most likely will fail.

@paveliak
paveliak requested a review from a team as a code owner August 31, 2023 00:16
Comment thread src/Runner.Sdk/ActionPlugin.cs Fixed
Comment thread src/Sdk/DTExpressions2/Expressions2/Sdk/EvaluationTraceWriter.cs Fixed
@paveliak
paveliak force-pushed the paveliak/http-redirects branch from f2f6848 to ad2beaf Compare August 31, 2023 18:34
Comment thread src/Runner.Worker/JobRunner.cs
Comment thread src/Runner.Worker/JobRunner.cs Outdated
@TingluoHuang
TingluoHuang merged commit 2b66cbe into actions:main Aug 31, 2023
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Sep 14, 2023
* Delegating handler for Http redirects

* Renamed varible name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants